This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Update TTD for locations where AsyncHooks passes hidden state. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfarnung
reviewed
May 22, 2017
src/async-wrap.cc
Outdated
| @@ -1,4 +1,4 @@ | |||
| // Copyright Joyent, Inc. and other Node contributors. | |||
| // Copyright Joyent, Inc. and other Node contributors. | |||
There was a problem hiding this comment.
Is a BOM getting added or removed here?
|
Hi Kyle, I cleaned up the BOM (looking) issue and updated the PR. |
kfarnung
reviewed
May 30, 2017
| #if ENABLE_TTD_NODE | ||
| if (s_doTTRecord || s_doTTReplay) { | ||
| unsigned int refcount = 0; | ||
| JsAddRef(*farray, &refcount); |
There was a problem hiding this comment.
Is AsyncWrap a singleton? If not, is this a memory leak since I never see a JsRelease anywhere?
There was a problem hiding this comment.
Looks like it is a singleton, nevermind.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
TTD, AsyncHooks
Description of change
AsyncHooks communicates between JS/Native using uncontrolled pointer writes. Add calls to notify TTD of these events.